Use weakref to make sure not holding the project

55995827 · Lin Jen-Shin · 29c1fd8b · 55995827
Commit 55995827 authored 7 years ago by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

app/controllers/application_controller.rb app/controllers/application_controller.rb +8 -2

No files found.
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -346,7 +346,13 @@ class ApplicationController < ActionController::Base
  def close_project_repository
    return unless @project

-    project = @project
-    ObjectSpace.define_finalizer(self, lambda { project.reload_repository! })
+    project = WeakRef.new(@project)
+    ObjectSpace.define_finalizer(self,
+      lambda do
+        begin
+          project.reload_repository! if project.weakref_alive?
+        rescue WeakRef::RefError
+        end
+      end)
  end
 end