Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #1294

Closed
Open
Created 12 years ago by Administrator@rootOwner
  • New issue

  • Report abuse

  • New issue

  • Report abuse

Note list rollup (for mergereq, for commit)

Closed

Note list rollup (for mergereq, for commit)

Created by: sroth80021

The note functionality in GitLab is really great. However, an issue we are seeing is that notes are easily missed, since they are only listed (as far as I know) in the appropriate container (file, etc).

It would be super-helpful to be able to see a rollup list of notes which apply to a mergereq or a commit, without having to scroll through each and every file/commit.

I think this would significantly increase the value of the note feature.

Linked issues
...

    Related merge requests

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: claudijd

      +1

      By Administrator on 2012-10-04T17:49:11 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: riyad

      +1

      By Administrator on 2012-10-04T19:12:05 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: asperling

      +1

      Yah, would have started a feature request of my own if it wasn't already done... Those comments are too easily missed. I've started reading a ruby book… because of gitlab. Maybe I can contribute on this some time soon.

      By Administrator on 2012-10-04T19:21:34 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: riyad

      @sroth80021 What do you mean with "rollup" exactly? Would #1629 and #1630 fix it?

      By Administrator on 2012-10-05T01:00:02 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: riyad

      @asperling Your contributions would be welcome. ;) Also Ruby is an awesome language to know. :)

      By Administrator on 2012-10-05T01:35:53 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: sroth80021

      @riyad This would be a huge improvement with the Merge Request part of this issue. By 'rollup', I just meant having a list of the issues, and this certainly addresses that. As a nice-to-have, it would be useful to have navigation from the issue list to the direct issue location, but that could be a future topic. ;-)

      The other part of this issue was for Commit reviews -- at least in GL 2.9, although it is possible to add notes to commit reviews, there is no single consolidated list in the commit review of all the per-commit notes (global notes, notes across all the commit files, etc). That would be very handy, for the same reasons as for the Merge Request.

      By Administrator on 2012-10-05T04:21:50 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: sroth80021

      ...continuing my previous comment re: commit reviews -- the reason this would be helpful, at least for us, is because we often use commit comments as a means for project team members to perform post-push reviews... basically reviews of code which has already been merged to the branch.

      For example, X merges code, it goes on whatever branch, and Y (on the same team) can do a review via GitLab commit note comments. Many of these do not go through the normal merge request process which we do use for larger scale changes.

      This is why both per-commit note listings and per-merge request note listings are both helpful.

      By Administrator on 2012-10-05T04:35:31 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: riyad

      @sroth80021 so, let me rephrase: what is still missing is the possibility to have a list of all the comments on a commit as a single list (i.e. not mixed into the diffs). (like the "Show line notes below" checkbox on GitHub; example on the bottom of 16ceae89) Do I understand you correctly?

      By Administrator on 2012-10-14T18:58:37 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: sroth80021

      @riyad yep, that's right. That's the part I think is missing.

      By Administrator on 2012-10-14T22:30:06 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: jleyrer

      +1

      By Administrator on 2012-10-17T16:50:40 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: riyad

      @sroth80021 We are working on #1878 to make things more obvious and easier to use. It doesn't (yet) but it will have the diff comments on the bottom thing. So please join the discussion there. Thanks. :)

      By Administrator on 2012-11-15T19:44:02 (imported from GitLab project)

    • Administrator
      Administrator @root · 12 years ago
      Owner

      Created by: sroth80021

      @riyad -- thanks for the improvements in this area. This is looking much better. :-)

      By Administrator on 2012-11-16T16:33:41 (imported from GitLab project)

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    Assign to
    Milestone
    No milestone
    None
    None
    Time tracking
    Due date
    None
    None
    0
    Labels
    None
    Assign labels
    • No matching results
    • Manage project labels
    Confidentiality
    Not confidential

    You are going to turn on confidentiality. Only team members with at least Reporter access will be able to see and leave comments on the issue.

    Lock issue
    Unlocked
    participants
    Reference:

    Menu

    Projects Groups Snippets
    Help