GitLab

Created by: fingermark

Using r12c01d74 (11/29's HEAD) and viewing the actual commit page ( /myproject/commits/d65ff486c9328f1021585b770463e739db9175ed) is showing the wrong Committed Date for a lot of my revisions. It shows 11 Nov 2011, 10:46am instead of the following that appears in git log:

Date: Tue Nov 29 15:46:13 2011 +0000

In fact, it appears to show 11 Nov 2011 for all of the dates that are incorrect. (Note, many are correct, which are usually older dates).

The date seems to appear correctly in the gitlab commit logs (where it has the "days ago" right).

Also, line 18 of show.html.haml has an incorrect spelling of "Committed Date".

Note: System time is correct. Dates are correct in git log.

Created by: fingermark

When I changed:

%td= @commit.committed_date.stamp("21 Aug 2011, 11:15pm")

to

%td= @commit.committed_date

The date is correct.

Also:

ruby-1.9.2-p180 :001 > require 'stamp' => true ruby-1.9.2-p180 :002 > date = Date.new(2011, 11, 12) => #<Date: 2011-11-12 (4911755/2,0,2299161)> ruby-1.9.2-p180 :003 > date.stamp("21 Aug 2011, 11:15pm") => "11 Nov 2011, 12:00am"

By Administrator on 2011-11-30T16:16:00 (imported from GitLab project)

Created by: fingermark

A quick fix would be to change it from "21 Aug 2011, 11:15pm" to "31 Aug 2011, 11:15pm"

ruby-1.9.2-p180 :031 > date.strftime_format("21 Aug 2011, 11:15pm") => "%m %b %Y, %I:%M%P" ruby-1.9.2-p180 :032 > date.strftime_format("31 Aug 2011, 11:15pm") => "%d %b %Y, %I:%M%P"

Also, see https://github.com/jeremyw/stamp/issues/10

By Administrator on 2011-11-30T16:27:09 (imported from GitLab project)

Created by: dzaporozhets

Checkout

https://github.com/gitlabhq/gitlabhq/commit/6686834c8ddee1bb74265eb696f6e26f8f5e5959 https://github.com/gitlabhq/gitlabhq/commit/c34092ebdcb597b0965df4d2c400672e4103e52d

By Administrator on 2011-11-30T19:25:35 (imported from GitLab project)

Created by: fingermark

Works. Thanks!

By Administrator on 2011-11-30T20:36:08 (imported from GitLab project)