Skip to content

GitLab

Closed
Created by Administrator@rootOwner

Commit data does not load for branch names that contain a forward slash '/'

Created by: mjdetullio

4.0 stable, production

Reproduce:

  1. Push a branch with a forward slash in it, i.e "feature/example"
  2. Open project in GitLab and click Files tab
  3. Use dropdown to select the newly pushed branch
  4. See "Loading commit data..." next to files/folders

The JSON request that is sent to retrieve the data returns a 404.

Production log shows:

Started GET "/my-namspace/my-project/feature/example/logs_tree/?_=1357598278507" for 127.0.0.1 at 2013-01-07 17:37:57 -0500
Processing by RefsController#logs_tree as JS
Parameters: {"_"=>"1357598278507", "project_id"=>"my-namespace/my-project/feature", "id"=>"example"}

The bottom line should show:

Parameters: {"_"=>"1357598278507", "project_id"=>"my-namespace/my-project", "id"=>"feature/example"}

Is there a particular file that handles the URL parsing for tree browsing that I can take a shot at? Or is there a patch available? I've done some rooting and haven't quite found what I'm looking for.