Incorrect check for .gitolite.rc for gitolite 2.3
Created by: 0xBF
$GL_GITCONFIG_KEY and $REPO_UMASK should be escaped:
diff --git a/lib/tasks/gitlab/check.rake b/lib/tasks/gitlab/check.rake
index baa706d..395579e 100644
--- a/lib/tasks/gitlab/check.rake
+++ b/lib/tasks/gitlab/check.rake
@@ -566,7 +566,7 @@ namespace :gitlab do
else
# assume older version
# see https://github.com/sitaramc/gitolite/blob/v2.3/conf/example.gitolite.rc#L49
- "$GL_GITCONFIG_KEYS"
+ "\\$GL_GITCONFIG_KEYS"
end
option_value = ".*"
if open(gitoliterc_path).grep(/#{option_name}\s*=[>]?\s*["']#{option_value}["']/).any?
@@ -595,7 +595,7 @@ namespace :gitlab do
else
# assume older version
# see https://github.com/sitaramc/gitolite/blob/v2.3/conf/example.gitolite.rc#L32
- "$REPO_UMASK"
+ "\\$REPO_UMASK"
end
option_value = "0007"
if open(gitoliterc_path).grep(/#{option_name}\s*=[>]?\s*#{option_value}/).any?