GitLab

Created by: cabello

Hi,

Looking at the code for versions 4.0 and 4.1, I see that if the note type is different than "commit" it will always come with the checkbox checked.

This is a problem for us because we have a team of ~ 60 people and we are using merge requests to do code review so when a developer review and adds 5 notes it fires 300 e-mails, of course you can uncheck the checkbox but it's not sticky so you have to remember to click for every note you make.

I was wondering if we could improve this checkbox a little bit to have the default business logic and a way to save, for some time half-our maybe, the option you chose for last time you made a note.

What you guys think about it?

• 4.1: https://github.com/gitlabhq/gitlabhq/blob/4-1-stable/app/views/notes/_form.html.haml#L37
• 4.0: https://github.com/gitlabhq/gitlabhq/blob/4-0-stable/app/views/notes/_common_form.html.haml#L25