Some API requests return a 404 when some other error code would be appropriate
Created by: Xylakant
Some calls to the API return a 404 when some other status code would be justified, for example the attempt to add a project member that already exists returns 404. In general, this pattern seems to be used quite often:
if users_project.save
@member = users_project.user
present @member, with: Entities::ProjectMember, project: user_project
else
not_found!Returning 404 in this case is not correct. If you really want to throw an error, 409 conflict might be appropriate, but given that this operation can be made idempotent, a 201 Created might be more appropriate in this case.