Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #2939

Closed
Open
Created 12 years ago by Administrator@rootOwner
  • New issue

  • Report abuse

  • New issue

  • Report abuse

All paths in configs must be expanded

Closed

All paths in configs must be expanded

Created by: qfox

If I pass symlinked path to configs my hooks doesn't work properly. Really discouraged bug. Probably it could be easily fixed on the config/initializers layer.

Linked issues
0

Related merge requests

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: qfox

    Use case: If you put git home directory to another device and symlink that to /home/git it will skip all push events because post_receive will send real path to repo. And PostReceive::perform will not work. I see it in logs.

    By Administrator on 2013-02-08T01:31:15 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: laradji

    I think i have this one, how can i test this ?

    By Administrator on 2013-02-26T09:08:29 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: zzet

    @zxqfox Can you get more information?

    We put git homedir into var: /var/git All repositories are placed into /var/git/repositories App placed in /some_dir/gitlab/releases/release_num/

    As you see, we not use default configs, but all is good.

    By Administrator on 2013-02-26T10:52:31 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: qfox

    @zzet I'm sure you will catch that bug when you move /var/git to /other/var/git, and then make a symlink from original to other path. mv /var/git /other/var/git && ln -s /other/var/git /var/git. I think the real trouble with symlinks because name of repo calculates from paths.

    By Administrator on 2013-02-26T12:52:05 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: zzet

    No. At first time we placed git user homedir on /home/git and created symlink to repositories: ln -s /var/git/repositories /home/git/repositories. No problems founded.

    @zxqfox why you create symlink? mb better to edit /etc/passwd with new homedir path?

    By Administrator on 2013-02-26T12:57:55 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: qfox

    @zzet Probably much better, But I believe it shouldn't crash with symlinks. Does that bug can be fixed using Pathname::realpath ?

    By Administrator on 2013-02-26T19:25:28 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: zzet

    @zxqfox I can not exactly answer now. Need tests and time. I think that this should solve the problem.

    By Administrator on 2013-02-26T19:46:10 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: dosire

    Moved to http://feedback.gitlab.com/forums/176466-general/suggestions/3788046-support-symlinked-paths

    By Administrator on 2013-03-27T08:56:47 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
Milestone
No milestone
None
None
Time tracking
Due date
None
None
1
Labels
Hooks
Assign labels
  • No matching results
  • Manage project labels
Confidentiality
Not confidential

You are going to turn on confidentiality. Only team members with at least Reporter access will be able to see and leave comments on the issue.

Lock issue
Unlocked
participants
Reference:

Menu

Projects Groups Snippets
Help