Skip to content

GitLab

Closed
Created by Administrator@rootOwner

[BUG] 'Files' can't display branches with '#'

Created by: mrohnstock

  1. Summary: Can't display 'Files', if branch contains '#'.
  2. Steps to reproduce:
    • Create a branch which contains '#' in name (i.e. "issue#62")
    • try to view Files of the branch
  3. Expected behavior: 'Files' gets displayed with Files of the branch containing '#'
  4. Observed behavior: gitlab sends "404 - The page you were looking for doesn't exist."
Started GET "/software/refs/switch?utf8=%E2%9C%93&ref=issue%2362&destination=tree&path=" for 127.0.0.1 at 2013-02-13 14:42:27 +0100
Processing by RefsController#switch as HTML
Parameters: {"utf8"=>"✓", "ref"=>"issue#62", "destination"=>"tree", "path"=>"", "project_id"=>"software"}
Redirected to http://localhost/software/tree/issue%2362/
Completed 302 Found in 23ms (ActiveRecord: 1.0ms)
Started GET "/software/tree/issue%2362/" for 127.0.0.1 at 2013-02-13 14:42:27 +0100
Processing by TreeController#show as HTML
Parameters: {"project_id"=>"software", "id"=>"issue#62"}
Completed 404 Not Found in 25ms
ActionController::RoutingError (No route matches {:controller=>"refs", :action=>"logs_tree", :project_id=>#<Project id: 6, name: "Software", path: "software", description: nil, created_at: "2012-12-17 14:15:56", updated_at: "2012-12-17 14:30:54", creator_id: 4, default_branch: "master", issues_enabled: true, wall_enabled: true, merge_requests_enabled: true, wiki_enabled: true, namespace_id: nil, public: false>, :id=>"issue#62", :path=>""}):
app/controllers/tree_controller.rb:15:in `show'
  1. Output of checks
Checking Environment ...

Git configured for www-data user? ... yes
Has python2? ... yes
python2 is supported version? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 1.4.0 ? ... OK (1.4.0)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by www-data:www-data? ... yes
Repo base access is drwxrws---? ... yes
post-receive hook up-to-date? ... yes
post-receive hooks in repos are links: ... 
Test ... ok
test-hardware ... ok
test-content ... ok
test-installer ... ok
test-software ... ok
test-site ... ok

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes

Checking Sidekiq ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
Projects have satellites? ... 
Test ... yes
test-hardware ... yes
test-content ... yes
test-installer ... yes
test-software ... yes
test-site ... yes
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.7.10)

Checking GitLab ... Finished

(I'm using use www-data not git, but this won't change anything).

GitLab: 5.2.0 (6654db2c) 7. Possible fixes: No idea