GitLab

Created by: m4tthumphrey

There is something very wrong with the method of closing issues via the API. Originally you could close and then reopen issue simply with the closed attribute (true or false) as part of the PUT request. Now it seems to be a complete mess...

1. There is a state property which contains the current state of the issue (closed or open (and possibly reopen)) but cannot be updated explicitly
2. You have to update the state_event property to update the state of the issue (completely undocumented - I had to look into /lib/api/issues.rb to see what was going on)
3. The documentation is so wrong - it currently states that you should pass closed as 1 to close an issue which simply does nothing
4. Once a comment has been closed you cannot reopen it any more because it is treated as deleted once you close it

I purposely haven't opened a pull request for this because I have no idea of @randx's intentions to this area. I believe the confusion was caused when the response codes were changed.

I will gladly take this on myself if I can get confirmation of how it should be handled.