"Other sign-in" broken when ldap is enabled in 5.1
Created by: fredrik-w
Hi,
After upgrading GitLab to 5.1 I noticed that the "Other sign-in" to use local sign-in isn't working when ldap is enabled. I just keep getting the "Invalid email or password." message. I've done some debugging and found the offending commit: 9d92433a. Specifically in the "devise.rb" [1] initializer, if I revert that minor change (":login" => ":email") both ldap and local logins work fine.
In "lib/api/session.rb" it seems like we're still sending the parameter name in as "email" rather than "login". Though my ruby isn't any good so I might be wrong.
Regards, Fredrik