creating a guest user ended up creating an admin user
Created by: gmsharky
One of our users (an admin of a team) added a user to his team as type Guest. I then explained that guests couldn't clone and he changed him to reporter. In the process of doing this, Gitlab reported a 500, and on investigating the user they were actually added as a Guest, but with Administrator ticked.
Here is (I believe) the associated server error
Parameters: {"utf8"=>"✓", "authenticity_token"=>"ZU9CY......cdaZgG8=", "team_member"=>{"permission"=>"20", "group_admin"=>"0"}, "team_id"=>"some-team", "id"=>"fred.smith"}
Completed 500 Internal Server Error in 18ms
ArgumentError (wrong number of arguments (3 for 4)):
lib/gitlab/user_team_manager.rb:78:in `update_team_user_access_in_project'
lib/gitlab/user_team_manager.rb:67:in `block in rebuild_project_permissions_to_member'
lib/gitlab/user_team_manager.rb:66:in `rebuild_project_permissions_to_member'
lib/gitlab/user_team_manager.rb:40:in `update_team_user_membership'
app/models/user_team.rb:90:in `update_membership'
app/controllers/teams/members_controller.rb:37:in `update'I am running commit version 951273ff