Skip to content

GitLab

Closed
Created by Administrator@rootOwner

Images attached on issues not showing

Created by: agb80

1.- Summary: Attach images to issues or comments must display a preview of the image inline with the issue or comment

2.- Steps to reproduce: On a Gitlab 5.2.0 stable branch. Attach an image on any issue or comment

3.- Expected behavior: Image preview displayed on each issue comment.

4.- Observed behavior: Just an empty placeholder image html tag

5.- Relevant logs and/or screen shots: nginx error log

2013/06/05 23:57:37 [crit] 28994#0: *24 stat() "/home/git/gitlab/public/" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /?limit=20&offset=0&_=1370494689144 HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:37 [crit] 28994#0: *24 stat() "/home/git/gitlab/public//index.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /?limit=20&offset=0&_=1370494689144 HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:37 [crit] 28994#0: *24 stat() "/home/git/gitlab/public/.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /?limit=20&offset=0&_=1370494689144 HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:37 [error] 28994#0: *24 connect() failed (111: Connection refused) while connecting to upstream, client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /?limit=20&offset=0&_=1370494689144 HTTP/1.1", upstream: "http://[::1]:9292/?limit=20&offset=0&_=1370494689144", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *24 stat() "/home/git/gitlab/public/uploads/note/attachment/250/home.png" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/250/home.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *24 stat() "/home/git/gitlab/public/uploads/note/attachment/250/home.png/index.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/250/home.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *24 stat() "/home/git/gitlab/public/uploads/note/attachment/250/home.png.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/250/home.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *26 stat() "/home/git/gitlab/public/uploads/note/attachment/244/compartir.png" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/244/compartir.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *26 stat() "/home/git/gitlab/public/uploads/note/attachment/244/compartir.png/index.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/244/compartir.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"
2013/06/05 23:57:39 [crit] 28994#0: *26 stat() "/home/git/gitlab/public/uploads/note/attachment/244/compartir.png.html" failed (13: Permission denied), client: 189.131.81.183, server: gitlab.fedrojesa.dtdns.net, request: "GET /uploads/note/attachment/244/compartir.png HTTP/1.1", host: "gitlab.fedrojesa.dtdns.net", referrer: "http://gitlab.fedrojesa.dtdns.net/"

6.- Output of checks Results of GitLab Application Check (sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production) Two errors showing: I have to change the startup script because default dosn't work on my Centos Box and because of centos, I'm currently on git 1.7.1 but none of those two errors are related to the bad behaivor currently showed.

Checking Environment ...

Git configured for git user? ... yes
Has python2? ... yes
python2 is supported version? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 1.4.0 ? ... OK (1.4.0)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
post-receive hook up-to-date? ... yes
post-receive hooks in repos are links: ... 
Agustín Cruz / fad ... ok
Agustín Cruz / Nereid ... ok

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes

Checking Sidekiq ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... no
  Try fixing it:
  Redownload the init script
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  Please fix the error above and rerun the checks.
Projects have satellites? ... 
Agustín Cruz / fad ... yes
Agustín Cruz / Nereid ... yes
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... no
  Try fixing it:
  Update your git to a version >= 1.7.10 from 1.7.1
  Please fix the error above and rerun the checks.

Checking GitLab ... Finished

Version of GitLab you are running: 5.2.0

Standar setup made using the manual.