Skip to content

GitLab

Closed
Created by Administrator@rootOwner

[6.1] Error 500 when closing an MR

Created by: maoueh

We had problem with repository satellite because of permission because of wrongly permissions on the satellite. After resolving this and edit then save the MR (to check availability), we tried to close it and gitlab returned error 500. Here the bug report.

  1. Summary: We closed an MR and an Error 500 was returned by Gitlab to the end-user. It seems that the issue was closed correctly though.
  2. Steps to reproduce: Not sure yet (at least, you need to close an MR), will report back with more information when/if the problem comes back.
  3. Expected behavior: The server should not return error 500. The MR seems to close itself though.
  4. Observed behavior: The server return a 500 error code, stack trace extract from production.log is appended at the end of the report.
  5. Results of GitLab Application Check: passes
  6. Describe your setup: CentOS 6.2 x64. Upgraded recently from 4.1 to 6.1 (4.1 to 4.2, 4.2 to 5.0, 5.0 to 5.1, 5.1 to 5.4, 5.4 to 6.0, 6.0 to 6.1).
  7. Possible fixes: No known yet.
Started PUT "/fabrig/backend/merge_requests/85?merge_request%5Bstate_event%5D=close" for 127.0.0.1 at 2013-10-03 16:14:55 -0400
Processing by Projects::MergeRequestsController#update as HTML
  Parameters: {"authenticity_token"=>"xnbsOZmB1ULKx0xa2DbLeHrl1EJitFsLZldJI64M230=", "merge_request"=>{"state_event"=>"close"}, "project_id"=>"fabrig/backend", "id"=>"85"}
  Rendered projects/merge_requests/_form.html.haml (25.7ms)
  Rendered projects/merge_requests/edit.html.haml within layouts/projects (29.2ms)
Completed 500 Internal Server Error in 941ms

ActionView::Template::Error (undefined method `empty?' for nil:NilClass):
    27:           .pull-left
    28:              
    29:             %i.icon-code-fork
    30:             = f.select(:target_branch, @target_branches, { include_blank: "Select branch" }, {class: 'target_branch chosen span2'})
    31:         .mr_target_commit.prepend-top-10
    32:
    33:   %hr

  app/views/projects/merge_requests/_form.html.haml:30:in `block in _app_views_projects_merge_requests__form_html_haml___2733303311994726247_33548620'
  app/views/projects/merge_requests/_form.html.haml:1:in `_app_views_projects_merge_requests__form_html_haml___2733303311994726247_33548620'
  app/views/projects/merge_requests/edit.html.haml:4:in `_app_views_projects_merge_requests_edit_html_haml___228942521921009987_34113940'
  app/controllers/projects/merge_requests_controller.rb:84:in `update'