gitlab-shell check fails after 6.2.4 e48313f7 update
Closed
gitlab-shell check fails after 6.2.4 e48313f update
Created by: sriharshav
Updated from 6.2.0 to 6.2.4 e48313f7
Update went on smoothly, but gitlab:check throws error on gitlab-shell check
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
/home/git/repositories: OK
/home/git/.ssh/authorized_keys: OK
: /home/git/gitlab-shell/bin/check:25:in `exists?': can't convert nil into String (TypeError)
from /home/git/gitlab-shell/bin/check:25:in `block in <main>'
from /home/git/gitlab-shell/bin/check:23:in `each'
from /home/git/gitlab-shell/bin/check:23:in `<main>'
gitlab-shell self-check failed
Try fixing it:
Make sure GitLab is running;
Check the gitlab-shell configuration file:
sudo -u git -H editor /home/git/gitlab-shell/config.yml
Please fix the error above and rerun the checks.
Checking GitLab Shell ... Finished
Created by: sriharshav
OK I got old gitlab-shell config where there is no entry for redis. With new change by @KaosMcRage it now checks for redis-cli binary.
By Administrator on 2013-11-14T17:47:52 (imported from GitLab project)
Created by: wKovacs64
I take it you guys are using really old gitlab-shell config files? The redis-cli binary path option has been in config.yml since v1.3.0. Maybe we can check for existence of options before evaluating and report an outdated/malformed config file if not found.
Edit: Would something like this be better than the error you received and an acceptable solution?
Check GitLab API access: OK Check directories and files: /home/git/repositories: OK /home/git/.ssh/authorized_keys: OK ERROR: missing option, check for malformed/outdated config file
By Administrator on 2013-11-14T23:44:27 (imported from GitLab project)
Created by: Javex
Added pull request to fix this: https://github.com/gitlabhq/gitlab-shell/pull/112
By Administrator on 2013-11-15T00:58:50 (imported from GitLab project)
Created by: sriharshav
@KaosMcRagei my setup started with gitlab 2.1 and since then I updated every version. I touched gitlab-shell only during gitlab 5.0 upgrade. I guess gitlab-shell 1.3 got shipped with gitlab 5.1 but I there is no mention of redis setting neither in release notes nor in upgrade guide. So far I didn't realise what I missed because of this old configuration. As the setting says it is used for pushing commit notices to gitlab, then it should have impacted some functionality, can you provide some background about this?
By Administrator on 2013-11-15T02:04:34 (imported from GitLab project)
Created by: wKovacs64
@blackst0ne Well, I was reluctant to put the literal name of the config file in the message in case it changes, plus config.yml is currently the only config file (this is specifically a gitlab-shell issue, not GitLab itself) so it should be obvious. But it looks like @Javex beat me to it on submitting a fix so it's moot now. :)
@sriharshav I would suggest with each upgrade you compare your config files to the example files that come with the new version. I believe the upgrade guides remind you to do this for the GitLab config files, but they don't seem to mention the gitlab-shell config file except Step 3 in the 5.0-to-5.1 upgrade (they probably should, especially with all the changes lately). I would check them every time, just in case. As for the redis configuration options being introduced in v1.3.0, yes, I would expect it to have impacted functionality if you didn't use a config file with the options present. Your activity feed would probably not show commit messages (the repository itself would be fine). If you have been seeing commit messages in the activity feed this whole time, I can't explain that. It's probably a question better suited for @randx or one of the other core developers. I am only a user/fan and minor contributor.
By Administrator on 2013-11-15T02:37:29 (imported from GitLab project)
Created by: sriharshav
@KaosMcRage yes I agree with you. I used to check gitolite config, but stopped bothering ever since we moved to gitlab-shell. That is a miss on my part. But curiously, activity feed seems to be normal. Anyway thanks for reply, I will try to give another check at it.
By Administrator on 2013-11-15T03:58:19 (imported from GitLab project)
Created by: sriharshav
gitlab-shell#112 is now accepted.
By Administrator on 2013-11-23T16:19:42 (imported from GitLab project)