GitLab

Created by: lurdan

Steps to reproduce

I've not able to grab the root cause, but it seems to happen when it shows multiple files and multiple blocks.

Expected behavior

gitlab shows lines which inlcuded in plain diff only.

Observed behavior

gitlab adds some empty lines at bottom of the diff block.

It's not so harmful because it doesn't drop/change original information, but some people can see it literally.

Relevant logs and/or screenshots

The plain diff: is interpreted to:

Output of checks

System information
System:         Debian 7.2
Current User:   git
Using RVM:      no
Ruby Version:   1.9.3p392
Gem Version:    2.0.3
Bundler Version:1.3.5
Rake Version:   10.1.0

GitLab information
Version:        6.2.3
Revision:       b490fde
Directory:      /home/git/gitlab
DB Adapter:     mysql2
URL:            <snip>
HTTP Clone URL: <snip>
SSH Clone URL:  <snip>
Using LDAP:     no
Using Omniauth: no

GitLab Shell
Version:        1.7.4
Repositories:   /home/git/repositories/
Hooks:          /home/git/gitlab-shell/hooks/
Git:            /usr/bin/git

Checking Environment ...

Git configured for git user? ... yes
Has python2? ... yes
python2 is supported version? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 1.7.4 ? ... OK (1.7.4)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
update hook up-to-date? ... yes
update hooks in repos are links: ...
<snip>
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
        /home/git/repositories: OK
        /home/git/.ssh/authorized_keys: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ...
<snip>
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.7.10)

Checking GitLab ... Finished

Possible fixes

I have no idea.