500 Encoding Error when viewing commits with unicode characters in branchname
Created by: nudgegoonies
I created a branch inside the test project called täte as a test and made a commit. I click on the commit in gitlab and get the 500 Encoding error.
This ist the production log:
Encoding::CompatibilityError (incompatible character encodings: UTF-8 and ASCII-8BIT):
app/views/projects/commit/_commit_box.html.haml:49:in `_app_views_projects_commit__commit_box_html_haml__356847883316487170_75490980'
app/views/projects/commit/show.html.haml:1:in `_app_views_projects_commit_show_html_haml___912579123390075438_75432940'
app/controllers/application_controller.rb:54:in `set_current_user_for_thread'
Rendered errors/encoding.html.haml within layouts/errors (3.4ms)
Rendered layouts/_head.html.haml (4.2ms)
Rendered layouts/_search.html.haml (99.7ms)
Rendered layouts/_head_panel.html.haml (111.3ms)
Rendered layouts/_flash.html.haml (0.4ms)
Completed 500 Internal Server Error in 688.4ms (Views: 127.3ms | ActiveRecord: 2.5ms)
This is the output of the check (removed project names [...]):
Checking Environment ...
Git configured for git user? ... yes
Has python2? ... yes
python2 is supported version? ... yes
Checking Environment ... Finished
Checking GitLab Shell ...
GitLab Shell version >= 1.7.9 ? ... OK (1.8.0)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
update hook up-to-date? ... yes
update hooks in repos are links: ...
[...]
Running /var/lib/gitlab/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
/var/lib/gitlab/repositories: OK
/var/lib/gitlab/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.4.15
Send ping to redis server: PONG
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking GitLab ...
Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ...
[...]
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.7.10)
Checking GitLab ... Finished
The gitlab version used is 6.3.0 and the gitlab-shell version used is 1.8.0
P.S. I tried 6.4.0.pre2 in a VM with our live data with the same result.