Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #5768

Closed
Open
Created 11 years ago by Administrator@rootOwner
  • New issue

  • Report abuse

  • New issue

  • Report abuse

Web/System hooks not retried if remote server returns non-200 error code.

Closed

Web/System hooks not retried if remote server returns non-200 error code.

Created by: bladealslayer

It seems that executing Web and System hooks ignores the return code of the remote server. As a result a hook calls with return code 4xx or 5xx from the remote server are considered successful and not retried.

See https://github.com/gitlabhq/gitlabhq/blob/master/app/models/web_hook.rb#L31.

Perhaps if the return code should be checked and exception raised on non-200 return code?

I can submit a PR, if you think this is the right way to go, @randx.

Linked issues
...

    Related merge requests

    • Administrator
      Administrator @root · 11 years ago
      Owner

      Created by: jvanbaarsen

      @randx What do you think?

      By Administrator on 2014-01-13T20:25:08 (imported from GitLab project)

    • Administrator
      Administrator @root · 11 years ago
      Owner

      Created by: jvanbaarsen

      Ping @randx

      By Administrator on 2014-03-02T17:08:57 (imported from GitLab project)

    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: bladealslayer

      This still seems unresolved. I'll submit a PR based on what I've done in our gitlab installation.

      By Administrator on 2014-08-07T10:11:21 (imported from GitLab project)

    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: Razer6

      ❤

      By Administrator on 2014-08-07T10:40:07 (imported from GitLab project)

    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: bladealslayer

      See #8343.

      By Administrator on 2014-11-18T11:10:07 (imported from GitLab project)

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    Assign to
    Milestone
    No milestone
    None
    None
    Time tracking
    Due date
    None
    None
    0
    Labels
    None
    Assign labels
    • No matching results
    • Manage project labels
    Confidentiality
    Not confidential

    You are going to turn on confidentiality. Only team members with at least Reporter access will be able to see and leave comments on the issue.

    Lock issue
    Unlocked
    participants
    Reference:

    Menu

    Projects Groups Snippets
    Help