Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #5770

Closed
Open
Created Dec 05, 2013 by Administrator@rootOwner

lib/gitlab/regex.rb: default_regex doesn't allow a preceding dot in filenames

Created by: wKovacs64

Scenario: Try to use the (+) plus sign to add a file to a project. Enter a filename that begins with a period (example: .gitignore). Fill out the other fields and try to commit.

Expected Result: Valid commit.

Actual Result: Receive an error stating "Your changes could not be commited, because file name contains not allowed characters" and no commit is made.

Possible Solution: It seems fixable by changing the regex to the following:

\A[\.a-zA-Z0-9][a-zA-Z0-9_\-\.]*(?<!\.git)\z

Unfortunately, this may allow for undesired filenames such as .. so someone with more regex experience may want to evaluate.

Assignee
Assign to
Time tracking