Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #61

Closed
Open
Created Oct 25, 2011 by Administrator@rootOwner

Code Diff - accurate line numbers

Created by: StephenBrown2

In github when viewing the code changes in a commit, the diff line numbers are the same as the actual numbers in the file. In the gitlab demo, they start at 1 or some other number, regardless of where in the file that change resides.

Note I have only just viewed the live demo yesterday and not yet installed it on my own server.

This can be seen on any indiviudal commit diff, for example the link in Issue #30 (closed): http://demo.gitlabhq.com/rails/commits/daca35c394dd490aeeaad9074141d7d86e9efb2c#actionpack/lib/action_controller/test_case.rb

Or even from the latest commit: Commit view: http://demo.gitlabhq.com/diaspora/commits/ae1fedc73b06367f7dc4ffa6b2f735530c8ccc6e Tree view: http://demo.gitlabhq.com/diaspora/tree/ae1fedc73b06367f7dc4ffa6b2f735530c8ccc6e/app/views/layouts/_header.html.haml

The numbers simply do not match up.

Assignee
Assign to
Time tracking