GitLab

Created by: thewholelifetolearn

My issue is similar to #3556 (closed) and #5044 .

The links between Markdown files when they are relative works but only in the master branch. When you go through a branch, the links refer to the wiki.

I' have upgraded GitLab from v6.1.0 to v6.5.1, one major version at a time this morning. I don't know if in 6.2., 6.3. and 6.4.* the issue is encountered too as I didn't do full tests. @vagari mentions in https://github.com/gitlabhq/gitlabhq/issues/3556#issuecomment-32286310 that the links do work in 6.4 .

It would be great if it works right again. In any case, thanks to all developers that contribute to GitLab.

Created by: thewholelifetolearn

A small update on the issue. I realized the problem appears also in forks! Even in the master branch.

The links in the fork link to the wiki. That doesn't happen if the project isn't a fork.

By Administrator on 2014-01-28T14:15:54 (imported from GitLab project)

Created by: maxlazio

@thewholelifetolearn The branch issue you are mentioning I cannot replicate in master. We also have tests for this which test if the links are updated when navigating through the branches and all of them are green on multiple runs now. Issue with forks is something new so I will be looking into that as soon as I can.

By Administrator on 2014-01-29T10:43:11 (imported from GitLab project)

Created by: zzet

@maxlazio sorry, I think you are wrong. Tests cover only "master branch case". This also reflected in the test name.

I think in satellites you do not do checkout to branch with markdown file. As default - master branch. And file are not present in directory, while file are present. I'm right?

By Administrator on 2014-01-29T10:50:49 (imported from GitLab project)

Created by: maxlazio

@zzet You are incorrect. https://github.com/gitlabhq/gitlabhq/blob/master/features/steps/project/project_markdown_render.rb#L93 (this remark is about the tests)

By Administrator on 2014-01-29T12:47:01 (imported from GitLab project)

Created by: zzet

@maxlazio Ok. And you check files, which are present in master branch.

By Administrator on 2014-01-29T12:47:50 (imported from GitLab project)

Created by: maxlazio

@zzet Correct. The issue described here explains that if you switch branches the links become links to wiki. That is correct only if the branch doesn't contain the files themselves. If the files exist in the branch, the links contain the correct ref.

By Administrator on 2014-01-29T12:53:44 (imported from GitLab project)

Created by: zzet

@maxlazio

• checkout to any branch (not master)
• add file
• edit another .md file and paste relative link to first file
• reproduced. You see link to wiki instead link to file.

By Administrator on 2014-01-29T13:19:44 (imported from GitLab project)

Created by: maxlazio

@zzet New branch, added new file, edited readme md to point to the new file. Still not being able to reproduce this. Links correctly point to the file 6.6.0.pre b75777fd

By Administrator on 2014-01-29T13:27:53 (imported from GitLab project)

Created by: zzet

• checkout another branch
• do something, after which satellite checkout to another branch (for example add new file)
• cd /to/satellite/of/current/project/
• git branch
• now satellite in another branch like

$ git branch
  __parking_branch
* another branch

• open your .md with any branch from first sample.
• all works correctly?

By Administrator on 2014-01-29T13:37:34 (imported from GitLab project)

Created by: thewholelifetolearn

As the forge is on enterprise network, it is not accessible from Internet.

I will try to put an example before the end of the week.

By Administrator on 2014-01-29T19:59:59 (imported from GitLab project)

Created by: maxlazio

@thewholelifetolearn I've accepted zzet MR which had a nice solution to make the links in the branch less brittle. This will be in 6.6 53bdcb53 If the issue still persists let me know after you upgrade to 6.6

By Administrator on 2014-01-30T08:19:42 (imported from GitLab project)