Skip to content

GitLab

Closed
Created by Administrator@rootOwner

Error 500 on Dir containing submodules in 6.6 stable

Created by: acheloos-m

1) Summary Trying to access a repositories directory which contains a Submodule throws a Error 500 after Update to 6.6.

2) How to reproduce Repo->Files->{Your directory with submodule} No experience with Vagrant, but i guess adding a submodule to a branch and then pushing it to the repo should do the job.

3) Expected behavior A list of my files and/or my Submodule Repo in File-List

4) Observed behavior No access to that particular part of gitlab - error 500

5) Relevant logs and/or screenshots

Started GET "/tigr***/tig***/tree/develop/templates/tigres-td" for 127.0.0.1 at 2014-02-22 11:17:32 +0100
Processing by Projects::TreeController#show as HTML
  Parameters: {"project_id"=>"tig***/tig***", "id"=>"develop/templates/tigres-td"}
  Rendered shared/_ref_switcher.html.haml (3.2ms)
  Rendered projects/repositories/_download_archive.html.haml (4.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_tree_item.html.haml (15.8ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_spinner.html.haml (0.1ms)
  Rendered projects/tree/_blob_item.html.haml (13.8ms)
  Rendered projects/tree/_submodule_item.html.haml (1.7ms)
  Rendered projects/tree/_tree.html.haml (38.2ms)
  Rendered projects/tree/show.html.haml within layouts/projects (47.5ms)
Completed 500 Internal Server Error in 117ms

ActionView::Template::Error (wrong number of arguments (0 for 1)):
    1: - tree, commit = submodule_links(submodule_item)
    2: %tr{ class: "tree-item" }
    3:   %td.tree-item-file-name
    4:     = image_tag "submodule.png"
  app/models/repository.rb:151:in `method_missing'
  app/models/repository.rb:199:in `submodule_url_for'
  app/helpers/submodule_helper.rb:6:in `submodule_links'
  app/views/projects/tree/_submodule_item.html.haml:1:in `_app_views_projects_tree__submodule_item_html_haml__1172003258568910478_69859603063640'
  app/helpers/tree_helper.rb:19:in `render_tree'
  app/views/projects/tree/_tree.html.haml:45:in `_app_views_projects_tree__tree_html_haml___4520425265560207752_69859602193220'
  app/views/projects/tree/show.html.haml:6:in `_app_views_projects_tree_show_html_haml__2178457144357207850_69859568642920'
  app/controllers/projects/tree_controller.rb:6:in `show'
  app/controllers/application_controller.rb:57:in `set_current_user_for_thread'

6) Output of Checks

sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production
Checking Environment ...

Git configured for git user? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 1.7.9 ? ... OK (1.8.0)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
update hook up-to-date? ... yes
update hooks in repos are links: ... 
*** / tig***.de - Tiger ... ok
*** / tie***.de ... ok
*** / qb-***.de ... ok
*** / tig*** - TD ... ok
*** / bor***de ... ok
*** / wal***.de ... ok
*** / abc***.de Eagle ... ok
*** / fs-***.de Harpy ... ok
*** / p***.de Whale ... ok
*** / mal*** ... ok
*** / rd-*** ... ok
*** / tigr*** ... ok
*** / cap***... ok
*** / vit***.de ... ok
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files: 
    /home/git/repositories: OK
    /home/git/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.2.12
Send ping to redis server: PONG
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ... 
*** / tig***.de - Tiger ... yes
*** / tie***.de ... yes
*** / qb***.de ... yes
*** / tigr*** ... yes
*** / bor***.de ... yes
*** / wal***.de ... yes
*** / abc***.de Eagle ... yes
*** / fs-***.de Harpy ... yes
*** / p***.de Whale ... yes
*** / mal*** ... yes
*** / rd-*** ... yes
*** / tig*** ... yes
*** / cap*** ... yes
*** / vit*** ... yes
Projects have satellites? ... 
*** / tig***.de - Tiger ... yes
*** / tie***.de ... yes
*** / qb-***.de ... yes
*** / tig***- TD ... yes
*** / bor***.de ... yes
*** / wal***.de ... yes
*** / abc***.de Eagle ... yes
*** / fs-***.de Harpy ... yes
*** / p***.de Whale ... yes
*** / mal*** ... yes
*** / rd-*** ... yes
*** / tig*** ... yes
*** / cap*** ... yes
*** / vit***.de ... yes
Redis version >= 2.0.0? ... yes
Your git bin path is "/usr/local/bin/git"
Git version >= 1.7.10 ? ... yes (1.8.4)

Checking GitLab ... Finished

Version affected: 6.6.0-stable SHA1: 490f99d4

Used Setup: Ubuntu 12.04 / Plesk / Nginx, see below (everything was fine with 6.5):

sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
(in /home/git/gitlab)

System information
System:     Ubuntu 12.04
Current User:   git
Using RVM:  no
Ruby Version:   2.0.0p353
Gem Version:    2.0.14
Bundler Version:1.3.5
Rake Version:   10.1.1

GitLab information
Version:    6.6.0
Revision:   490f99d
Directory:  /home/git/gitlab
DB Adapter: mysql2
URL:        http://***.de
HTTP Clone URL: ********
SSH Clone URL:  ********
Using LDAP: no
Using Omniauth: no

GitLab Shell
Version:    1.8.0
Repositories:   /home/git/repositories/
Hooks:      /home/git/gitlab-shell/hooks/
Git:        /usr/local/bin/git