Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #6506

Closed
Open
Created Mar 10, 2014 by Administrator@rootOwner

Touch detection in Modernizr unreliable, so it shouldn't be used

Created by: jerbob92

Also see this: https://github.com/Modernizr/Modernizr/issues/880 and https://github.com/gitlabhq/gitlabhq/commit/8b3b6f1096497ad63bbd4cd9bf78fa913ae345b5#diff-09616b394d980733fe84edaa552eb9c8

Summary: The new mobile improvements use this to disable the tooltips on touch devices, but the "touch" from Modernizr isn't reliable, it only tells if the browser supports touch events. This causes that my FF 27 on Ubuntu Desktop gets the touch class, and doesn't show tooltips.

Steps to reproduce:

  • Open Gitlab in Firefox 27 on Ubuntu Desktop and test the date tooltips (or any other tooltip). Might not work on other browsers, but only tested on that one.

Expected behavior: The tooltip works when I hover the date.

Observed behavior: The tooltip does not work, it's being hidden by a css rule.

Possible fixes: https://github.com/gitlabhq/gitlabhq/commit/8b3b6f1096497ad63bbd4cd9bf78fa913ae345b5#diff-09616b394d980733fe84edaa552eb9c8

Maybe add an extra class hidden-xs, or just remove the css line, not sure if it's even needed.

Assignee
Assign to
Time tracking