Merge Request email subjects
Created by: rspeicher
So revision 3d7194f0 introduced, among other things, this method, which appears to override the subject method of Notify. That's fine, except that it doesn't. It never even gets called. This might have been noticed sooner if there had been any tests for it.
On top of not actually working, the thing it's trying to do isn't done very well. Why re-create the entire subject method when we could just unshift the new information onto the extras var and call super? Why do we sometimes use @merge_request and other times just use merge_request, seemingly at random?
Should I try fixing it? Do we want to just remove it since no one's seemed to miss it so far?
ping @karlhungus