Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #7342

Closed
Open
Created Jul 21, 2014 by Administrator@rootOwner

Merge Request Comments: how should they work?

Created by: darinkes

Hi,

Setup: GitLab 7.0.0 de9bf7da

When a merge request gets opened, and some devs discuss about a line of code in the merge request, a new Discussion about this line gets opened, e.g.:

Stefan Rinkes started a discussion on this merge request diff README.md:L19

Now the dev fixes the line of code and pushes the fixed commit with force (git push -f) to the merge request.

But some other dev also doesn't like the fix in the updated merge request and wants to comment the current line of code. This comment gets attached to discussion about the old line of code. I don't think this is the wanted behavior. Since this behavior makes it impossible to discuss a line of code in an updated merge request.

Quite complicated to describe :/ I hope I didn't missed the point :)

Assignee
Assign to
Time tracking