Merge Request Comments: how should they work?
Closed
Merge Request Comments: how should they work?
Created by: darinkes
Hi,
Setup: GitLab 7.0.0 de9bf7da
When a merge request gets opened, and some devs discuss about a line of code in the merge request, a new Discussion about this line gets opened, e.g.:
Stefan Rinkes started a discussion on this merge request diff README.md:L19
Now the dev fixes the line of code and pushes the fixed commit with force (git push -f) to the merge request.
But some other dev also doesn't like the fix in the updated merge request and wants to comment the current line of code. This comment gets attached to discussion about the old line of code. I don't think this is the wanted behavior. Since this behavior makes it impossible to discuss a line of code in an updated merge request.
Quite complicated to describe :/ I hope I didn't missed the point :)
Created by: darinkes
As extra information (just noticed after writing the issue):
In the inline diff no comment is shown, also the expected ones. In the side-by-side diff all comments, the expected ones and unexpected ones, are shown.
By Administrator on 2014-07-21T12:34:42 (imported from GitLab project)
Created by: jacob-carlborg
The discussion tab always shows all comments. The changes tab always shows the latest code. I'm not sure if it's possible to have the behavior you're suggesting. If a line has a couple of comments. Then that line is removed, now there is no line to attached the comments to in the changes tab.
By Administrator on 2014-11-20T10:37:31 (imported from GitLab project)
Created by: senthilkumarkj
We're using GitLab 7.0 and we have the same issue. With 6.x, even when we do force push, comments were preserved (under discussion tab) in the merge request and it was hugely helpful. With 7 they just disappear.
By Administrator on 2015-02-12T01:34:59 (imported from GitLab project)
