Make upgrade script transactional
Created by: za-creature
I tried upgrading from 7.1.1 facfec4b to 7.3.2 f092e53e without having cmake installed. The upgrade script crashed at:
An error occurred while installing rugged (0.21.0), and Bundler cannot continue.
Make sure that `gem install rugged -v '0.21.0'` succeeds before bundling.
While this is probably normal (or at the very least, not your problem), attempting to run the upgrader after installing cmake produced the following:
GitLab 7 upgrade tool
Your version is 7.3.2
Latest available version for GitLab 7 is 7.3.2
You are using the latest GitLab version
It seems that while a git stash is performed pre-update, no revert is done in the event that the installation fails. This should probably be fixed as I had to manually run the commands defined in Gitlab.Upgrader.update_commands
to finish the installation.