GitLab

Created by: jk

When I do a compare on a large changeset I get a 500 error code. From time to time I see this error on small changesets, too, but I don't know what causes it.

The URL I request: https://example.com/project/commits/compare?utf8=✓&from=4966344786284a79c553a5ad19d47de04b1be68d&to=a3960baba8fb9d6ef49ac3f09f9276db4d13920f&commit=Compare

from log/production.log:

Started GET "/jobstairs-ios/commits/compare?utf8=%E2%9C%93&from=4966344786284a79c553a5ad19d47de04b1be68d&to=a3960baba8fb9d6ef49ac3f09f9276db4d13920f&commit=Compare" for 192.168.104.21 at 2012-05-22 18:31:18 +0200
Processing by CommitsController#compare as HTML
  Parameters: {"utf8"=>"✓", "from"=>"4966344786284a79c553a5ad19d47de04b1be68d", "to"=>"a3960baba8fb9d6ef49ac3f09f9276db4d13920f", "commit"=>"Compare", "project_id"=>"jobstairs-ios"}
  Rendered commits/_head.html.haml (12.0ms)
  Rendered commits/_commit.html.haml (325.0ms)
  Rendered commits/_diff_head.html.haml (720.8ms)
  Rendered commits/_text_file.html.haml (1.9ms)
  Rendered commits/_text_file.html.haml (1.4ms)
  Rendered commits/_diffs.html.haml (750.5ms)
  Rendered commits/compare.html.haml within layouts/project (1089.9ms)
Completed 500 Internal Server Error in 1326ms

ActionView::Template::Error (undefined method `text?' for #<Grit::Submodule "a8b0f0731ea585d7b7897a6ed8834c319c3e1635">):
    31:             %span{:id => "#{diff.new_path}"}= diff.new_path
    32:         %br/
    33:       .diff_file_content
    34:         - if file.text?
    35:           = render "commits/text_file", :diff => diff, :index => i
    36:         - elsif file.image?
    37:           .diff_file_content_image
  app/views/commits/_diffs.html.haml:34:in `block in _app_views_commits__diffs_html_haml__4419084282220725269_60121100'
  app/views/commits/_diffs.html.haml:18:in `each'
  app/views/commits/_diffs.html.haml:18:in `each_with_index'
  app/views/commits/_diffs.html.haml:18:in `_app_views_commits__diffs_html_haml__4419084282220725269_60121100'
  app/views/commits/compare.html.haml:32:in `_app_views_commits_compare_html_haml___3414249442523008313_54315020'

I use the latest stable (2.5), but that issue was already there on master 2 weeks ago or so.