Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #8986

Closed
Open
Created Mar 20, 2015 by Administrator@rootOwner

Updating comment with thumbs up emoji fails

Created by: johnou

When updating a comment with "👍" an error occurs and the ajax refresh fails.

Started PUT "/xxx/xxx/notes/4" for 193.64.35.129 at 2015-03-20 12:38:53 +0200 Processing by Projects::NotesController#update as JS Parameters: {"utf8"=>"✓", "authenticity_token"=>"xxx", "note"=>{"note"=>"👍"}, "commit"=>"Save Comment", "project_id"=>"xxx/xxx", "id"=>"4"} Completed 500 Internal Server Error in 96ms

ActionView::Template::Error (undefined method `each' for nil:NilClass):
    28:         %span.note-last-update
    29:           = note_timestamp(note)
    30:
    31:         - if note.superceded?(@notes)
    32:           - if note.upvote?
    33:             %span.vote.upvote.label.label-gray.strikethrough
    34:               %i.fa.fa-thumbs-up
  app/models/note.rb:495:in `superceded?'
  app/views/projects/notes/_note.html.haml:31:in `_app_views_projects_notes__note_html_haml___3629060394487211255_121248620'
  app/controllers/projects/notes_controller.rb:71:in `note_to_html'
  app/controllers/projects/notes_controller.rb:103:in `render_note_json'
  app/controllers/projects/notes_controller.rb:39:in `block (2 levels) in update'
  app/controllers/projects/notes_controller.rb:38:in `update'
Assignee
Assign to
Time tracking