Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #9923

Closed
Open
Created Dec 21, 2015 by Administrator@rootOwner

Notes inconsistency with updating

Created by: stevepeak

When updating notes, without providing Content-Type: multipart/form-data, the PUT results in 400 missing body argument (even when provided).

Here is how you replicate using Python.

# Failes
import requests
res = requests.put('https://gitlab.com/api/v3/projects/187725/merge_requests/59639/notes/3006211', 
                   headers={'Authorization': 'Bearer TOKEN'}, data='body=hello+world')
print res.text
>>> {"message":"400 (Bad request) \"body\" not given"}

# Works
res = requests.put('https://gitlab.com/api/v3/projects/187725/merge_requests/59639/notes/3006211', 
                   headers={'Authorization': 'Bearer TOKEN', 'Content-Type': 'multipart/form-data'}, data='body=hello+world')
print res.status_code
>>> 200

GitLab API's should assume multipart/form-data when no Content-Type header is provided. The API does accept requests from other endpoints when no Content-Type header is provided, as far as I've experienced it is only the Update Notes endpoint.

Assignee
Assign to
Time tracking