Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1465

Merged
Created 12 years ago by Administrator@rootOwner

Change comments order

  • Overview 9
  • Commits 20
  • Changes 30

Created by: riyad

Changes notes order in all circumstances except for the wall.

  • Notes are now oldest to newest, top to bottom (except for the project wall)
  • Refactored notes.js to be able to dynamically load ordinary and reversed notes
  • Properly documented notes.js
  • Fixed bugs regarding the handling (especially deletion) of diff line notes
  • Renamed the notes partials to be more consistently named
  • Extracted notes related stuff (from rendering diffs) into new notes partials

Closes #847 (closed)

Enjoy :)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
  1. 14 Sep, 2012 20 commits
    • Riyad Preukschas's avatar
      Update Notes JS for reversed notes · 07eec9c6
      Riyad Preukschas authored 12 years ago
      07eec9c6
    • Riyad Preukschas's avatar
      Add 'notes/reversed_notes_with_form' partial · 7563abbe
      Riyad Preukschas authored 12 years ago
      7563abbe
    • Riyad Preukschas's avatar
      Rename note.js to notes.js · e63d7b60
      Riyad Preukschas authored 12 years ago
      e63d7b60
    • Riyad Preukschas's avatar
      Extract 'notes/per_line_notes_with_reply' partial · e1ca155c
      Riyad Preukschas authored 12 years ago
      e1ca155c
    • Riyad Preukschas's avatar
      Extract 'notes/per_line_note_link' partial · a3dbd990
      Riyad Preukschas authored 12 years ago
      a3dbd990
    • Riyad Preukschas's avatar
      Rename 'notes/per_line_show' partial to 'notes/per_line_note' · c6d71b7b
      Riyad Preukschas authored 12 years ago
      c6d71b7b
    • Riyad Preukschas's avatar
      Renamed 'notes/notes_list' partial to 'notes/notes' · dd1b3177
      Riyad Preukschas authored 12 years ago
      dd1b3177
    • Riyad Preukschas's avatar
      Rename 'notes/show' partial to 'notes/note' · 4fc66ead
      Riyad Preukschas authored 12 years ago
      4fc66ead
    • Riyad Preukschas's avatar
      Rename 'notes/reply_button' partial to 'notes/per_line_reply_button' · 29c71f2f
      Riyad Preukschas authored 12 years ago
      29c71f2f
    • Riyad Preukschas's avatar
      Rename 'notes/form' partial to 'notes/common_form' · c02e3f21
      Riyad Preukschas authored 12 years ago
      c02e3f21
    • Riyad Preukschas's avatar
      Remove 'notes/load' partial · 3c02c93f
      Riyad Preukschas authored 12 years ago
      3c02c93f
    • Riyad Preukschas's avatar
      Rename 'notes/create_*' partials · 8fb70d92
      Riyad Preukschas authored 12 years ago
      8fb70d92
    • Riyad Preukschas's avatar
      Rename 'notes/notes' partial to 'notes/notes_with_form' · 61eb650d
      Riyad Preukschas authored 12 years ago
      61eb650d
    • Riyad Preukschas's avatar
      Update JS for adding and removing diff line notes · cee230a1
      Riyad Preukschas authored 12 years ago
      cee230a1
    • Riyad Preukschas's avatar
      Update links for inline comments to use data-* attributes · 653f7ec4
      Riyad Preukschas authored 12 years ago
      653f7ec4
    • Riyad Preukschas's avatar
      Update diff comments order and rendering · 20e009a4
      Riyad Preukschas authored 12 years ago
      20e009a4
    • Riyad Preukschas's avatar
      Completely redo loading of notes with JS · e802d009
      Riyad Preukschas authored 12 years ago
      e802d009
    • Riyad Preukschas's avatar
      Fix markup · 14164017
      Riyad Preukschas authored 12 years ago
      14164017
    • Riyad Preukschas's avatar
      Update Note to load notes in the right order · 6ffec9a2
      Riyad Preukschas authored 12 years ago
      6ffec9a2
    • Riyad Preukschas's avatar
      Reorder notes view elements · 8b6dba74
      Riyad Preukschas authored 12 years ago
      8b6dba74
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
No milestone
None
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Reference: gpt/large_projects/gitlabhq1!1465
Source branch: github/fork/riyad/change-notes-order

    0 pending comments

Menu

Projects Groups Snippets
Help