Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1597

Merged
Created Sep 30, 2012 by Administrator@rootOwner

Improve completion of emoji and team members

  • Overview 25
  • Commits 3
  • Changes 4

Created by: riyad

Improves on #1539 and #1551

  • Adds completion for all emoji
  • Only load auto-completion data if it's actually used (e.g. someone types @) This also improves loading times for pages with notes.
  • Use API for auto-completion of team members
  • Introduce the .gfm-input class for fields that accept GFM (works only with notes at the moment) and use them for setting up auto-completion.

Preparing the emoji data (when rendering) still slows the request down (try commenting out the call to the helper ;) ). But impact has been minimized by using to_s instead of to_json and doing the format mapping in JS (client-side) instead in Ruby (server-side).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/riyad/add-completion-for-all-emoji