Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1613

Merged
Created 12 years ago by Administrator@rootOwner

Improve performance of Commits#show

  • Overview 6
  • Commits 2
  • Changes 4

Created by: rspeicher

Commit#safe_message was getting called several times for every commit message, which slowed down the "Commit History" page quite a bit because it was constantly converting the same message to utf8.

Benchmarks:

Calling `commit.title` on the same commit, 500 times each run:

                         user     system      total        real
performance branch:  0.600000  17.450000  18.050000 ( 18.058806)
master branch:       2.520000 280.670000 283.190000 (283.191723)

In terms of actual performance, on the master branch it takes my system about 3.5 to 4 seconds to load the first page of the commit history for GitLab itself in the development environment, and after this change it takes about 800 ms. That number should still be lower, but this is a start.

Loading
Loading

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
Milestone
No milestone
None
None
Time tracking
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/rspeicher/performance

    0 pending comments