Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1617

Merged
Created Oct 03, 2012 by Administrator@rootOwner

Reject ssh keys that break gitolite

  • Overview 11
  • Commits 4
  • Changes 6

Created by: dosire

Without this code an invalid ssh key could break Gitlab for everyone. For example an ssh key with a space in the middle would pass validation but would give errors in each Gitolite operation.

The errors would look like:

remote: FATAL: fingerprinting failed for 'keydir/admin_local_host_1348232546.pub'

This PR solves this by fingerprinting as part of the validation process.

These commits are not squashed because we already needed to merge them into the gitlab.com repository to prevent this problem.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/dosire/reject-ssh-keys-that-break-gitolite