Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1878

Merged
Created Oct 31, 2012 by Administrator@rootOwner

Discussions (a.k.a. Grouped Comments)

  • Overview 26
  • Commits 47
  • Changes 70

Created by: riyad

This revamps the merge request comments section to group related comments (on commits and diffs) and shows a little context. There is also a lot of tidying up, fixing subtle deficiencies, inconsistencies and a few bugs.

  • group comments based on commit, commit diff line, merge request diff line
  • show context of embedded discussions
  • make discussions collapsible
  • fix icons and text for diff line links/buttons/form to be more consistent
  • truncate diff context only to the relevant parts
  • continuous loading only for the wall
  • update styling for note actions
  • allow previews and attachments everywhere
  • improve attachments
  • simplifying and cleaning CSS and JS

This is based on code, ideas and discussions from #1733. @kouno thanks again. :)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/riyad/discussions