Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1929

Closed
Created 12 years ago by Administrator@rootOwner
  • Report abuse
Report abuse

Fix UTF8 encoding problem.

  • Overview 6
  • Commits 1
  • Changes 1

Created by: SaitoWu

Relate to:

https://github.com/gitlabhq/gitlabhq/commit/cda5e66d7c190e852b23caca17d90df43d91d75e#commitcomment-2107925

update

We have two problems:

backend => ruby and frontend => coffee

This PR will fix backend problem

need to fix jquery.history plugin to solve the frontend problem

cc/ @tsigo

Request to merge github/fork/SaitoWu/master into master
  • Download as
  • Email patches

  • Plain diff

Checking approval status

Closed by (Jun 20, 2025 9:23am UTC)

The changes were not merged into master


  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: SaitoWu

    close this one, trying to use https://github.com/SaitoWu/grit_ext solve the encoding problem.

    By Administrator on 2012-11-06T12:37:47 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: rspeicher

    https://github.com/balupton/history.js/issues/228 probably related.

    By Administrator on 2012-11-06T17:01:22 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: riyad

    FYI: If I (left) click on a folder with a non-ascii name in the files view I get http://localhost:3000/gitlab/tree/non-ascii/test%20%C3%83%C2%A4%C3%83%C2%B6%C3%83%C2%BC If I open it in a new tab (i.e. middle click) I get http://localhost:3000/gitlab/tree/non-ascii/test%20%C3%A4%C3%B6%C3%BC

    It should actually always be like the 2nd one.

    By Administrator on 2012-11-06T17:11:15 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: riyad

    @SaitoWu would grit_ext solve both path and content encoding issues? If so, you are my hero. :)

    By Administrator on 2012-11-06T19:05:54 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: SaitoWu

    @riyad Yeap, It will solve Git's 4 basic objects encoding problem. ( blob tree commit tag.

    I mean will, need some time. :-)

    gitlab and other app which use grit_ext will not need to care the encoding problem.

    By Administrator on 2012-11-07T02:17:04 (imported from GitLab project)

  • Administrator
    Administrator @root · 12 years ago
    Owner

    Created by: SaitoWu

    Why we need to handle many and many encoding problem and github not, Its because github is running on MRI 1.8.

    And Grit is design for MRI 1.8, not for 1.9. Its the biggest different between we and github.

    By Administrator on 2012-11-07T02:33:51 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
No milestone
None
None
Time tracking
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/SaitoWu/master

    0 pending comments

Menu

Projects Groups Snippets
Help