Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !2054

Closed
Created Nov 23, 2012 by Administrator@rootOwner
  • Report abuse
Report abuse

Detect encoding of note attachment url.

  • Overview 1
  • Commits 1
  • Changes 3

Created by: maxlazio

If a user attaches a document that contains special characters in the filename( eg. çaão_riaá.doc) to a comment, comment is not displayed. PROJECT/files/ page will also give error 500. This PR solves that.

Unfortunately, the included test is passing even without the fix.

Travis build failed for postgresql but passed for mysql.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/dosire/attachments_with_special_characters