Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !2673

Merged
Created Jan 21, 2013 by Administrator@rootOwner

Render submodule bugfix

  • Overview 2
  • Commits 1
  • Changes 1

Created by: AlexDenisov

Have this error when submodule url is nil.

ActionView::Template::Error (can't convert nil into String):
    31:           %td
    32:           %td
    33:
    34:       = render_tree(tree.contents)
    35:
    36:     - if tree.readme
    37:       = render "tree/readme", readme: tree.readme
  app/helpers/tree_helper.rb:18:in `+'
  app/helpers/tree_helper.rb:18:in `block in render_tree'
  app/helpers/tree_helper.rb:15:in `each'
  app/helpers/tree_helper.rb:15:in `render_tree'
  app/views/tree/_tree.html.haml:34:in `_app_views_tree__tree_html_haml__1071874968_86634150'
  app/views/tree/show.html.haml:3:in `_app_views_tree_show_html_haml___680544721_79735610'
  app/controllers/tree_controller.rb:17:in `show'

Render empty string instead of nil fix this error.

P.S. right now I have no time to add tests on this case.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/AlexDenisov/submodule_rendering_bug