GitLab

Created by: hiroponz

Attention: This problem is not occured on development mode. I have tested by chrome.

Before:

After:

Closes #1145 (closed)

Created by: Razer6

Related to #1145 (closed)

By Administrator on 2013-01-24T07:10:55 (imported from GitLab project)

Created by: riyad

If you propose a "hack" like this, you should also add a comment with a reason or a link where the issue was discussed. :) Also it should be easily be found (by tools like rake notes) and removed at a future date. I advise you to add something like:

-# FIXME: fixes a rendering bug in Chrome (see https://github.com/gitlabhq/gitlabhq/issues/1145)

By Administrator on 2013-01-24T16:11:43 (imported from GitLab project)

Created by: dzaporozhets

Does it really an only solution?

By Administrator on 2013-01-24T20:41:07 (imported from GitLab project)

Created by: hiroponz

Exchanging month and day also looks good.

Reason: The number of the head of the line in html source is not displayed, because of chrome bug. For example, "13" is not displayed, if html source is like following.

Modified:

diff --git a/app/views/commits/_commits.html.haml b/app/views/commits/_commits.html.haml
index e7ed971..3215284 100644
--- a/app/views/commits/_commits.html.haml
+++ b/app/views/commits/_commits.html.haml
@@ -2,5 +2,5 @@
   %div.ui-box
     %h5.title
       %i.icon-calendar
-      = day.stamp("28 Aug, 2010")
+      = day.stamp("Aug 28, 2010")
     %ul.well-list= render commits

Screenshot:

By Administrator on 2013-01-25T01:43:20 (imported from GitLab project)

Created by: dzaporozhets

I cannot reproduce bug on Vista + Chrome 23 and w7 + chrome 23. Do we really need this hack just? As I know google updates browser automatically.

By Administrator on 2013-01-25T08:31:04 (imported from GitLab project)

Created by: mrohnstock

Can't reproduce with chrome 24.0.1312.56 (177594) on linux x86_64 in production, too.

By Administrator on 2013-01-25T09:12:00 (imported from GitLab project)

Created by: hiroponz

I can reproduce bug on w7 + chrome 24.0.1312.56.

In passing, this problem is not occured on development mode.

By Administrator on 2013-01-25T08:53:26 (imported from GitLab project)

Created by: dzaporozhets

so only production yes?

On Fri, Jan 25, 2013 at 10:53 AM, Hiroyuki Sato notifications@github.comwrote:

I can reproduce bug on w7 + chrome 24.0.1312.56.

In passing, this problem is not occured on development mode.

— Reply to this email directly or view it on GitHubhttps://github.com/gitlabhq/gitlabhq/pull/2735#issuecomment-12692654.

Best regards, Dmitriy

By Administrator on 2013-01-25T09:00:33 (imported from GitLab project)

Created by: hiroponz

Yes, only production. Because of haml behavior, html is indented on development, but not on production.

By Administrator on 2013-01-25T09:10:03 (imported from GitLab project)

Created by: dzaporozhets

closed in favor of 8016a7bd

By Administrator on 2013-01-25T12:19:30 (imported from GitLab project)