Skip to content

GitLab

Closed
Created by Administrator@rootOwner
Report abuse

Fix for broken commit_url in graph

Created by: poremland

Fix the broken commit_url.

Loading
Loading
  • Administrator
    Administrator @root started a thread on commit 3a26f034
    app/views/projects/graph.html.haml
    11 11 $(function(){
    12 12 branch_graph = new BranchGraph($("#holder"), {
    13 13 url: '#{url_for controller: 'projects', action: 'graph', format: :json}',
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commits/%s'
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commit/%s'
    • Administrator
      Administrator @root ·
      Owner

      Created by: riyad

      Why not fix it to point to the proper controller? i.e. url_for controller: 'commit', action: 'show'

      By Administrator on 2013-01-24T16:01:18 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 3a26f034
    app/views/projects/graph.html.haml
    11 11 $(function(){
    12 12 branch_graph = new BranchGraph($("#holder"), {
    13 13 url: '#{url_for controller: 'projects', action: 'graph', format: :json}',
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commits/%s'
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commit/%s'
    • Administrator
      Administrator @root ·
      Owner

      Created by: poremland

      That gives a routing error:

      Started GET "/git/android/graph" for 127.0.0.1 at 2013-01-24 08:58:59 -0800 Processing by ProjectsController#graph as HTML Parameters: {"id"=>"android"} Rendered projects/graph.html.haml within layouts/project_resource (3.0ms) Completed 500 Internal Server Error in 25ms

      ActionController::RoutingError (No route matches {:controller=>"commit", :action=>"show"}): app/views/projects/graph.html.haml:14:in _app_views_projects_graph_html_haml__290458963_99150210' app/controllers/projects_controller.rb:94:ingraph'

      By Administrator on 2013-01-24T17:00:15 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 3a26f034
    app/views/projects/graph.html.haml
    11 11 $(function(){
    12 12 branch_graph = new BranchGraph($("#holder"), {
    13 13 url: '#{url_for controller: 'projects', action: 'graph', format: :json}',
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commits/%s'
    14 commit_url: '#{url_for controller: 'projects', action: 'show'}/commit/%s'
    • Administrator
      Administrator @root ·
      Owner

      Created by: dzaporozhets

      any reason why we cannot use project_commit_path here?

      By Administrator on 2013-01-24T20:45:25 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    Closed in favor of 097e6053

    By Administrator on 2013-01-25T08:16:34 (imported from GitLab project)

Please register or sign in to reply