Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !2993

Closed
Created Feb 14, 2013 by Administrator@rootOwner
  • Report abuse
Report abuse

Add feature to support email-less omniauth backends

  • Overview 3
  • Commits 1
  • Changes 2

Created by: raphendyr

If backend do not provide auth.info.email, We generate it from auth.info.nickname and email_domain option passed to omniauth provider (if it's passed).

You should be able to pass this option to all allready implemented omniauth providers and this commit fixes it for ldap.

This feature is usefull in environments wherre login is done by LDAP, pam, shibboleth or similar and that backend is not providing email. (ldap is missing email field. pam can't normally know it. etc..)

This more generalized version of #2589

This PR is untested, but it's copy-paste from version that is in production in our system (https://github.com/raphendyr/gitlabhq/commit/c5c9136bb469137f40aae7019b97fe199e78bf9e).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/raphendyr/email_if_non_from_omniauth