Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !3052

Merged
Created Feb 20, 2013 by Administrator@rootOwner

System hooks code & logic refactoring

  • Overview 1
  • Commits 4
  • Changes 4

Created by: Andrew8xx8

We must stop to place logic in observers. It's not scalable, clean and also this code is hard to testing.

Let's go to include Service Layer.

Good resources about Service Layer:

http://collectiveidea.com/blog/archives/2012/06/28/wheres-your-business-logic/

http://blog.firsthand.ca/2011/10/rails-is-not-your-application.html

http://blog.carbonfive.com/2012/01/10/does-my-rails-app-need-a-service-layer/

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/Undev/system-hook-observer-improves