Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !3387

Closed
Created Mar 25, 2013 by Administrator@rootOwner
  • Report abuse
Report abuse

Fix Error 500 if Pygments can not hilight a code block in the Readme

  • Overview 6
  • Commits 2
  • Changes 1

Created by: dunkelstern

When browsing a project file tree and there is a Readme file in the repository in some cases the Pygments syntaxhilighter can not process some code blocks and throws an exception (when python interpreter is not called python2). So I included a simple safeguard around the syntax hilighter to fall back to a standard 'pre'-block if Pygments raises an exception. So it renders the page at least not throwing a "500 Internal Server Error".

I know about https://github.com/gitlabhq/gitlabhq/issues/2214#issuecomment-11137058 but i think fixing this such a way it falls back to not hilighted simple code blocks could be a better option than to explode and throw a 500.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/dunkelstern/fix-readme