Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !5292

Closed
Created Oct 08, 2013 by Administrator@rootOwner
  • Report abuse
Report abuse

Implement PAM on top of gitlab 6-1-stable

  • Overview 12
  • Commits 4
  • Changes 18

Created by: raphendyr

This is working implementation for our environment (as required for now).

I created this PR as a notation that implementing omnitauth stuff in gitlab will eventually render omniauth abstraction useless as code is copied from omniauth gem's to gitlab (lib/gitlab/{ldap,pam}/user.rb) and thus requires code in gitlab repository for every omniauth backend.

Instead of this we should find a way to fix omniauth in a way that suites our needs. That means we need to implement interface for ldap and pam auhtentication methods. Also we need a way to know how different backends are supposed to be shown on sign in page (button or form).

You can argue that this is not our job (as it's not), but we are the ones who need this fixed.

I had some ideas in omniauth issue, but they didn't want to do those now: https://github.com/intridea/omniauth/issues/691

As gitlab allready uses it's fork for omniauth-ldap, it could fork omniauth and fix these issues for ldap. I very happily implement these on omniauth-pam.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/raphendyr/6-1-pam