Skip to content

GitLab

Merged
Created by Administrator@rootOwner

Unused http_url member in project & gollum_wiki

Created by: archiloque

Request to merge github/fork/archiloque/unused_http_url into master
Checking approval status

Merged by (Jun 20, 2025 4:09pm UTC)

The changes were merged into master with 4ab31d83

The source branch has been deleted

  • Administrator
    Administrator @root ·
    Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-15.01%) when pulling 4ab31d83 on archiloque:unused_http_url into 4e878ad9 on gitlabhq:master.

    By Administrator on 2013-12-02T10:45:26 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 4ab31d83
    app/models/gollum_wiki.rb
    33 33 end
    34 34
    35 35 def http_url_to_repo
    36 http_url = [Gitlab.config.gitlab.url, "/", path_with_namespace, ".git"].join('')
    • Administrator
      Administrator @root ·
      Owner

      Created by: dzaporozhets

      maybe cache then?

      @http_url ||= [Gitlab.config.gitlab.url, "/", path_with_namespace, ".git"].join('')

      By Administrator on 2013-12-02T12:38:33 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 4ab31d83
    app/models/gollum_wiki.rb
    33 33 end
    34 34
    35 35 def http_url_to_repo
    36 http_url = [Gitlab.config.gitlab.url, "/", path_with_namespace, ".git"].join('')
    • Administrator
      Administrator @root ·
      Owner

      Created by: archiloque

      Why storing it if it's not useful ? On the contrary as it's only used in views it may be more appropriate to move it to a helper.

      By Administrator on 2013-12-02T12:43:57 (imported from GitLab project)

Please register or sign in to reply

Menu

Help