Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !5764

Closed
Created 11 years ago by Administrator@rootOwner
  • Report abuse
Report abuse

modified css path

  • Overview 5
  • Commits 1
  • Changes 4

Created by: wndfly

Loading
Loading

  • Administrator
    Administrator @root · 11 years ago
    Owner

    Created by: jvanbaarsen

    @wndfly What is the reason for this fix? What is the issue you are trying to resolve?

    By Administrator on 2013-12-05T12:14:21 (imported from GitLab project)

  • Administrator
    Administrator @root · 11 years ago
    Owner

    Created by: ghost

    @jvanbaarsen It appears that this would help when not running GitLab in the root directory (using the relative_url_root config option).

    By Administrator on 2013-12-05T20:51:30 (imported from GitLab project)

  • Administrator
    Administrator @root · 11 years ago
    Owner

    Created by: jvanbaarsen

    The only problem is that for the 404, lets say you have: http://demo.gitlab.com/sandbox/afro/sdfsdfsdf and the http://demo.gitlab.com/sandbox/afro/ portion of the path exists.

    The page wont load the CSS when you remove the front / so im not sure this PR doesn't break anything.

    By Administrator on 2013-12-05T20:55:05 (imported from GitLab project)

  • Administrator
    Administrator @root · 11 years ago
    Owner

    Created by: ghost

    You are correct @jvanbaarsen. I didn't think about that before. The only way this pull request would work is if those pages were hit from redirects. As they are rendered in the path of the resource, this probably will not work. However, is still a problem when using the relative_url_root.

    By Administrator on 2013-12-06T14:23:31 (imported from GitLab project)

  • Administrator
    Administrator @root · 11 years ago
    Owner

    Created by: jvanbaarsen

    This pull request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the pull request guidelines in our contributing guidelines we will reopen this pull request. /cc @Razer6

    By Administrator on 2013-12-19T12:06:13 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
Milestone
No milestone
None
None
Time tracking
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/wndfly/6-3-stable

    0 pending comments

Menu

Projects Groups Snippets
Help