Skip to content

GitLab

Merged
Created by Administrator@rootOwner

Add index_merge_request_diffs_on_merge_request_id

Created by: gussan

Improve MergeRequestDiff performance

Request to merge github/fork/gussan/add_index_merge_request_diffs_on_merge_request_id into master
Checking approval status

Merged by (Jun 20, 2025 11:18am UTC)

The changes were merged into master with 93bc67ab

The source branch has been deleted

  • Administrator
    Administrator @root ·
    Owner

    Created by: mjdetullio

    @gussan Are the benefits of this change seen on just the MR comments/diff page or also on the MR list page?

    @randx I just upgraded from 6.4 -> 6.5 -> 6.6 and I'm seeing a noticeable performance hit on the MR list page. I had one project with 17 open MRs and when I loaded the MR list page it took ActiveRecord 20 seconds. Another project with 5 MRs open takes 3.2 seconds. Switching the filter from Open to All exceeds my 30 second Unicorn timeout. I believe this page is trying to load a significant amount of information from the merge_request_diffs table.

    By Administrator on 2014-03-11T18:11:30 (imported from GitLab project)

Please register or sign in to reply

Menu

Help