Skip to content

GitLab

Closed
Created by Administrator@rootOwner
Report abuse

notes counts in 1 query

Created by: skv-headless

I like it because:

  1. It ~60ms faster
  2. It reduce number of sql queries in views
Loading
Loading
  • Administrator
    Administrator @root started a thread on commit d92f07d1
    app/models/note.rb
    120 120
    121 121 discussions
    122 122 end
    123
    124 def counts_for_commits(commits)
    • Administrator
      Administrator @root ·
      Owner

      Created by: jvanbaarsen

      Can you please make sure this public method is covered by an unit test?

      By Administrator on 2014-04-05T16:07:09 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit d92f07d1
    spec/models/note_spec.rb
    282 282 end
    283 283 end
    284 284
    285 describe '#counts_for_commits' do
    286 let(:project) { create(:project) }
    287 let!(:note) { create(:note_on_commit, note: "+1 from me") }
    288 let!(:commit) { note.noteable }
    289
    290 it 'should return commit and its count' do
    291 counts = Note.counts_for_commits([commit])
    292 counts[commit.id] == 1
    • Administrator
      Administrator @root ·
      Owner

      Created by: dzaporozhets

      I think you missed should here

      By Administrator on 2014-04-06T07:31:13 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.

    By Administrator on 2014-04-21T11:36:51 (imported from GitLab project)

Please register or sign in to reply