Skip to content

GitLab

Merged
Created by Administrator@rootOwner

Proposal for split testing

Created by: jvanbaarsen

What does this MR do? This PR is a proposal to change the way we currently run our tests. Because lots of the time travis will stop testing, because the limit of 50 minutes has passed.

By adding tags to tests (like I did on models/assembla_service_spec.rb and features/gitlab_flavored_markdown_spec.rb) we can split the tests up in smaller tasks. That way every task will take less time, and Travis will not time-out that often.

Are there points in the code the reviewer needs to double check? If there is a possibility that we might skip a test this way (I dont think so, because of the rake testing:other task, but just to be sure, please take a look).

Please keep in mind that this is just a Prove of Concept, so the full implementation needs still to be done.

Why was this MR needed? See What does this MR do

Request to merge github/fork/jvanbaarsen/split_tests into master
Approval is optional

Merged by (May 13, 2025 5:11am UTC)

The changes were merged into master with 490ab228

The source branch has been deleted

  • Administrator
    Administrator @root started a thread on commit 490ab228
    spec/features/gitlab_flavored_markdown_spec.rb
    1 1 require 'spec_helper'
    2 2
    3 describe "GitLab Flavored Markdown" do
    3 describe "GitLab Flavored Markdown", features: true do
    • Administrator
      Administrator @root ·
      Owner

      Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2014-04-11T19:53:05 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 490ab228
    spec/features/gitlab_flavored_markdown_spec.rb
    1 1 require 'spec_helper'
    2 2
    3 describe "GitLab Flavored Markdown" do
    3 describe "GitLab Flavored Markdown", features: true do
    • Administrator
      Administrator @root ·
      Owner

      Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2014-04-11T19:53:05 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    @randx / @maxlazio Can you take a look at this proposal?

    By Administrator on 2014-04-11T11:41:21 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    I think its enoug to add api tag to api specs. And no need to override rspec tasks. Just add to travis.yml rspec --tag api and rspec --tag ~api

    By Administrator on 2014-04-11T19:24:01 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    @randx Ok, but dont split the models and feature specs?

    By Administrator on 2014-04-11T19:25:33 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    @jvanbaarsen yes. I think with future api growth it will be only api and other unit tests. So this split up should be enough

    By Administrator on 2014-04-11T19:26:29 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    @randx The problem with the travis specs is, they refer to a seperate rake task (The one i refactored). So i cant just put --tag api in the,.

    By Administrator on 2014-04-11T19:26:59 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    @jacobvosmaer than you can jsut add new rake tasks like spec:api and spec:unit or something like this. And instead of rake spec use this new tasks

    By Administrator on 2014-04-11T19:28:58 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    @randx Ok! Thanks for the feedback! Will work this out later tonight :)

    By Administrator on 2014-04-11T19:29:41 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    The point is not touch rake spec task so I can use it for running all specs with db setup like it is now

    By Administrator on 2014-04-11T19:30:06 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    @jvanbaarsen thank you! I like you put this problem with travis timeout. Its really annoying

    By Administrator on 2014-04-11T19:30:30 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    @randx Are you sure that spec/requests are the only part of the rspec test suite that takes super long?

    By Administrator on 2014-04-11T19:42:18 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: dzaporozhets

    thanks

    By Administrator on 2014-04-11T19:58:52 (imported from GitLab project)

  • Administrator
    Administrator @root ·
    Owner

    Created by: jvanbaarsen

    Hope this will help a little! Otherwise i'll break it up even further (if you dont mind)

    By Administrator on 2014-04-11T20:00:29 (imported from GitLab project)

Please register or sign in to reply

Menu

Help