Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !6860

Merged
Created Apr 24, 2014 by Administrator@rootOwner

Add support for side-by-side inline comments

  • Overview 13
  • Commits 1
  • Changes 4

Created by: hszcg

  • Only display inline comments for changed lines
  • Support reply to existing inline comments
  • DO NOT display inline comment for matched lines
    • Because we do not have line_code for matched lines in side-by-side mode
    • And I am not sure where should i put this comment, on the left or on the right?
    • We could support this by modifying in https://github.com/gitlabhq/gitlabhq/blob/master/app/helpers/commits_helper.rb#L108
  • DO NOT support adding new inline comments
    • First, we also need line_code for matched lines
    • Second, it may involve more code changes. I could do it, but maybe in another pull-request.

Inline Mode screen shot 2014-04-24 at 8 55 49 pm

Side-by-side Mode screen shot 2014-04-24 at 8 49 00 pm

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/hszcg/dev