GitLab

Created by: skv-headless

http://localhost:3000/gitlabhq/gitlab-ci/merge_requests/1/diffs#note_316 scroll in such links doesn't work. It happens because on page there are 2 elements with id="note_316" in changes and discussion. Browser takes first for scroll. This solution works because changes loads without diffs so tag with id="note_316" just one. Diffs loads with discussions, but in this case diff tag would be first. It is dirty but working solution.

Created by: skv-headless

bug

fix

also fixed scroll to this note.

By Administrator on 2014-05-29T07:52:02 (imported from GitLab project)

Created by: skv-headless

reproduced here https://gitlab.com/skv-headless/test_project/merge_requests/1/diffs#note_126261

By Administrator on 2014-06-10T06:08:15 (imported from GitLab project)

Created by: Razer6

@jvanbaarsen Can you take a look?

By Administrator on 2014-06-10T08:56:43 (imported from GitLab project)

Created by: jvanbaarsen

@skv-headless Just to be sure, doesn't this break the scrolling for the Discussion page?

By Administrator on 2014-06-10T09:21:50 (imported from GitLab project)

Created by: jvanbaarsen

@skv-headless Ok, i've just tested this locally, seems to work. Can you please rebase with master and ping me when ready?

By Administrator on 2014-06-10T09:30:50 (imported from GitLab project)

Created by: skv-headless

@jvanbaarsen rebased

By Administrator on 2014-06-10T12:29:29 (imported from GitLab project)

Created by: jvanbaarsen

@randx Looks ok!

By Administrator on 2014-06-10T12:32:41 (imported from GitLab project)